Modernize and clean up code (attempt 2)#7
Open
KonSola5 wants to merge 1 commit intoJstrisPlus:mainfrom
Open
Conversation
- Replaced `innerHTML` with `textContent` or `innerText` whenever `innerHTML` was used just to add text, not HTML, - Replaced `keyCode`s with `code`s whenever it was a key 100% handled by Jstris+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
innerHTMLwithtextContentorinnerTextwheneverinnerHTMLwas used just to add text,keyCodes withcodes whenever the key is 100% handled by JstrisPlus (changed the config field names from "_KEYCODE" to "_KEY" along the way),Known bug (which was present before, now it's modified): When refreshing the tab, "Enable chat timestamps" and "Take a screenshot with this button" keys are visually empty, but they still work. (
Config()for some reason is not initialized at the moment when keys are filled into the textfields).Attempt 2, because the forked repository kept adding changes I did not want here (such as modified license or a submodule), now it's done using a separate local git repository that only handles the jstris-plus branch.